Skip to content

Mapbox content bugfix #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwoznicki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mapbox content bugfix #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197e271
Fixed a bug where the metadata for an object with id 'mapbox-content'…
Jul 27, 2022
fb9880d
Added a test to ensure that metadata for objects with 'mapbox-content…
Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function generateLayoutInternal(options, callback) {
if (
options.extractMetadata &&
options.format &&
(img.svg.includes('mapbox-stretch') || img.svg.includes('mapbox-text-placeholder'))
(img.svg.includes('mapbox-stretch') || img.svg.includes('mapbox-text-placeholder') || img.svg.includes('mapbox-content'))
) {
const metaOps = { svg: img.svg, pixelRatio: options.pixelRatio };
extractMetadata(metaOps, (err, metadataProps) => {
Expand Down
9 changes: 9 additions & 0 deletions test/fixture/svg-metadata/au-national-route-5-only-content.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions test/generate.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,3 +373,29 @@ test('generateLayout with both placeholder and stretch zone', function (t) {
t.end();
});
});

test('generateLayout with only content', function (t) {
var fixtures = [
{
id: 'au-national-route-5-only-content',
svg: fs.readFileSync('./test/fixture/svg-metadata/au-national-route-5-only-content.svg')
}
];
spritezero.generateLayout({ imgs: fixtures, pixelRatio: 1, format: true }, function (err, formatted) {
t.ifError(err);
t.deepEqual(
formatted,
{
'au-national-route-5-only-content': {
width: 38,
height: 20,
x: 0,
y: 0,
pixelRatio: 1,
content: [3, 7, 23, 18],
}
}
);
t.end();
});
});