Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Conversation

@bkowshik
Copy link
Contributor

@bkowshik bkowshik commented Apr 4, 2017

There are a couple of compare functions with the old style callback format. Ex:

A majority of compare function have moved over to the new, plain return format. Ex:


@batpad @lukasmartinelli Any ideas how to make tests/test_compare_function.js work for both these use cases? In this PR, I have modified the test to work for the plain return format as that looks like the majority of the compare functions.


cc: @amishas157 @geohacker

@amishas157
Copy link
Contributor

@bkowshik

Any ideas how to make tests/test_compare_function.js work for both these use cases? In this PR, I have modified the test to work for the plain return format as that looks like the majority of the compare functions.

To make it work for all the compare functions, I added the commit to import compare functions from index file itself, which exports all compare functions as async functions.

Should that be fine?

cc @batpad

@amishas157
Copy link
Contributor

To clarify, the above commit does a bunch of things apart from solving above issue. This is the part of the commit which is specific to the above issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants