This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Test compare function with/without callback #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of compare functions with the old style
callbackformat. Ex:invalid_tag_combination.jsA majority of compare function have moved over to the new, plain return format. Ex:
added_place.js@batpad @lukasmartinelli Any ideas how to make
tests/test_compare_function.jswork for both these use cases? In this PR, I have modified the test to work for the plain return format as that looks like the majority of the compare functions.cc: @amishas157 @geohacker