Add "Dont show again" option to copyright element #1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phocacius
requested changes
Nov 21, 2025
src/Mapbender/CoreBundle/Resources/public/elements/MbCopyright.js
Outdated
Show resolved
Hide resolved
swinkelmann
force-pushed
the
feature/copyright-dontshow-again
branch
from
5ec45a9 to
3b452b4
Compare
astroidex
approved these changes
Nov 21, 2025
Member
astroidex
left a comment
astroidex
left a comment
There was a problem hiding this comment.
Tested functionality. Works fine.
- copyright will be displayed again, when text is changed
- Reactivation works
- Also activation via button
astroidex
requested changes
Nov 21, 2025
Phocacius
approved these changes
Nov 25, 2025
Member
|
Approved. Can be merged. No everything is ok. |
Member
|
PR to add the new copyright configuration to mapbender_user.yaml see mapbender/mapbender-starter#159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check whether this is the desired behaviour.
internal ticket:
#11338