Refer-A-Friend System prepared for s1980 adopted from archiv s1699

[Hikarii]

This is a (nearly) 1:1 copy of the Refer-A-Friend System of the archiv repository at https://github.com/mangos-one/server-old

Taken from

• mangosArchives/Mangos-One-server-old@00cb8bb
• mangosArchives/Mangos-One-server-old@6a37d17

Signed-off-by: Salja salja2012@hotmail.de

[Hikarii]

Typo: Should be setConfig(CONFIG_FLOAT_RATE_RAF_LEVELPERLEVEL, "Rate.RAF.LevelPerLevel", 0.5f);

[Salja]

some more need fixed the patch make a traget bug i think the patch need a full rewirte

[Hikarii]

You talk about the target bug by summoning a friend by using the corresponding context menu option, while targeting another player, NPC or creature, which leads to fail the spell, right?

[Salja]

yes thats i mean =) and i think some we can make better in the code some more clean etc

[Hikarii]

I've some suggestions for the new system. I've read blizzards article about refer a friend and I've found that there are more conditions which are missing in the current system.

• CONFIG_UINT32_RAF_MAXGRANTLEVEL should also affect CONFIG_FLOAT_RATE_RAF_XP. Above the given level there will be no longer bonus xp.
• CONFIG_UINT32_RAF_MAXGRANTLEVEL should also affect the summonig spell. players with level equal or lower than the value can be summoned. Above not.
• If the level difference between the players ar bigger than 3 (former it was 4, which includes tbc), then only the lower one gain bonus xp the other gain normal xp.
• You can only grant a level to a character which is below your own level.
• The bonus xp of the refer a friend system should be shown in the combat log (like the rested bonus).

These informations are from blizzards system for Mist of Pandaria. Whether this matchs the situation back in The Burning Crusade... I don't know.

[billy1arm]

@Hikarii - Do you think you can get this fixed up so that we can attempt testing on it ?

[Hikarii]

@billy1arm I don't know. I'll try it. What do you want to be fixed? The suggestions I made above?

[billy1arm]

@Hikarii yes please

[Hikarii]

@billy1arm Currently the RAF system is in its original state, how it was back in rel 12.1. Hence untested for Rel 19!
I haven't pushed the fix for reputation gain yet. I can do that yet, if you want.
Unfortunately I haven't made any progress in the context menu targeting issue mentioned above.

[billy1arm]

@Hikarii - could you push the 'reputation gain fix' ?