feat: implement all-in-memory StreamingEncrypt without disk dependent #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
requested changes
Sep 2, 2025
Member
grumbach
left a comment
grumbach
left a comment
There was a problem hiding this comment.
Nice one! Although this approach is quite hard to use. Why don't we simplify it to a single function that takes in a byte iterator and returns a chunk iterator?
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub fn new_from_memory(file_size: usize, chunk_store: F) -> Result<Self> { |
Member
There was a problem hiding this comment.
Maybe just new would be enough? And to be even more generic size instead of file_size would be great as we're not necessarily dealing with files.
Comment on lines
+324
to
+342
| /// let storage = Rc::new(RefCell::new(HashMap::new())); | ||
| /// let storage_clone = Rc::clone(&storage); | ||
| /// let store_chunk = move |hash: XorName, content: Bytes| -> self_encryption::Result<()> { | ||
| /// let _ = storage_clone.borrow_mut().insert(hash, content.to_vec()); | ||
| /// Ok(()) | ||
| /// }; | ||
| /// | ||
| /// let file_size = 10_000; | ||
| /// let mut encryptor = StreamingEncrypt::new_from_memory(file_size, store_chunk)?; | ||
| /// | ||
| /// // Process first chunk of data | ||
| /// let data1 = Bytes::from(vec![1u8; 5000]); | ||
| /// let result1 = encryptor.encrypt_part(0, data1)?; | ||
| /// assert!(result1.is_none()); // Not complete yet | ||
| /// | ||
| /// // Process second chunk of data | ||
| /// let data2 = Bytes::from(vec![2u8; 5000]); | ||
| /// let result2 = encryptor.encrypt_part(5000, data2)?; | ||
| /// assert!(result2.is_some()); // Complete! Returns DataMap |
Member
There was a problem hiding this comment.
This is kind of hard to use, I feel like this could be done in one function call without the whole indexing process which is very error prone.
Member
|
Replaced by #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamingEncryptwithout disk dependent, to be consistent withStreamingDecryptstreaming_encrypt_from_filehelper function to utilise the newStreamingEncryptStreamingDecryptintostream_decrypt.rs, and putStreamingEncryptintostream_decrypt.rs