Move block crate into this repo
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of supplying an extern fn, a simpler native rust fn is supplied and the BlockArguments trait is used to get an extern fn that wraps it.
Previous code was just assigning to an uninitialzed field, so the compiler was dropping it; by changing this to a ptr::write the existing value is no longer dropped.
The old behavior can be replicated by creating a custom closure with a context and function.
Platforms beside OSX and iOS will link to libBlocksRuntime.
It isn't necessary now that travis-ci/apt-package-safelist#2949 is fixed.
When updating to current Rust, there is a warning for a change in the output due to the change in Markdown implementations.
The `gcc` crate has been replaced with `cc`. Additionally, the `gcc:Config` was renamed to `gcc::Build`. This updates both of those. Commit taken from SSheldon/rust-block#8
This also adds A: EncodeArguments and R: Encode bounds on blocks, which is a good idea to require given that the types are being sent to and from Objective-C!
It's also actually nicer to have examples that use the current crate!
madsmtm
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure previously whether I wanted to do this in #1, but after seeing that I really want to add
Encodestuff in it, it seemed like a good idea. This PR also adds those bounds and implementations, which fixes theobjc_foundation/blockfeature!(There had already been work on this in a
dev_encodebranch)This also includes the fix for SSheldon/rust-block#8.