-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
osxbom: switch to lib-style dependency on libunwind #28635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why are the libmacho and libmacho-headers dependencies needed at all? I tried removing them from the port and was still able to build it. |
I think they were discovered by trace mode |
|
I asked because I recalled a previous instance where I dealt with libmacho and could not understand why we had ports for it when it's part of the OS. Apparently the libmacho we have in MacPorts is newer than what is in old macOS so I guess that's better for some things. I also kind of assumed it was like libunwind in causing problems for other ports, but perhaps the problem is not general. (The above-referenced ticket was specific to wine and the user intentionally disabling other ports' universal variants which wine needed.) Per another old ticket, the libmacho-headers port is intended to be used when you're using the libmacho port. You're using one but not the other. Would the libmacho library be used if you added a dependency on that port? If so, let's add that. And if not, how does this port use the headers but not the library? |
|
@cooljeanius is there any indication that there is an issue with |
|
Feel free to reopen once you have responded to the review comments. |
The configure script checks for |
...oh right, |
|
OK, uh... where is the "reopen" button? |
...actually... I think I screwed something up when attempting to rebase; I'm just going to open a new one... |
OK, done in #30477 |
In https://trac.macports.org/ticket/66250 it says that Macports-built libunwind can cause problems with other ports. This PR tweaks
osxbom's dependency on libunwind to use alib:-style dependency instead, so that the system libunwind can satisfy it instead.Description
Type(s)
Tested on
macOS 15.5 24F74 x86_64
Xcode 16.4 16F6
Verification
Have you
port lint?sudo port test?sudo port -vst install?