Replace libsodium with pure-Rust alternatives #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the libsodium dependency and replace with the same functionality from rust-crypto ecosystem crates. `Encryptor` & `Decryptor` traits added to facilitate custom crypto operations, e.g. via a remote service
Author
|
I should point out that the new traits are hidden behind the original encrypt/decrypt_key functions and not yet exposed in the API :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I'm working on, I wanted to use
macaroonin a WebAssembly module (wasm32-wasi target). Unfortunately, libsodium makes this difficult if not impossible.I've republished my fork with the changes for testing, but I wanted to see if there was any interest in bringing this upstream.
The main change is the replacing of libsodium with the following crates:
Additionally I refactored the crypto stuff around the
EncryptorandDecryptortraits -- the idea being to allow the client to provide it's own encryption mechanism via a service like Vault for example.This also takes care of #83 and #84!