Skip to content

refactor: Create Interfaces for Events #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexs-mparticle merged 7 commits into from
Jan 15, 2025
Merged

refactor: Create Interfaces for Events #962

alexs-mparticle merged 7 commits into from
Jan 15, 2025

Conversation

@alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Jan 7, 2025 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Create Interface Definitions for Events

Testing Plan

  • Was this tested locally? If not, explain why.
  • N/A - This PR only defines new interfaces

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle force-pushed the refactor/SQDSDKS-5593-event-interface-ts branch from f6af349 to d527b43 Compare January 7, 2025 22:09
@alexs-mparticle alexs-mparticle changed the title Refactor/sqdsdks 5593 event interface ts refactor: Create Interfaces for Events Jan 7, 2025
@alexs-mparticle alexs-mparticle marked this pull request as ready for review January 7, 2025 22:18
rmi22186
rmi22186 requested changes Jan 13, 2025
View reviewed changes
rmi22186
rmi22186 requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple more comments

alexs-mparticle and others added 2 commits January 15, 2025 10:09
@alexs-mparticle
Address PR Comments
c3bcf9f
@alexs-mparticle @rmi22186
Update src/mp-instance.js
9082411 
Co-authored-by: Robert Ing <rmi22186@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alexs-mparticle alexs-mparticle merged commit d494364 into refactor/ts-migration-blackout-2024 Jan 15, 2025
24 of 29 checks passed
alexs-mparticle added a commit that referenced this pull request Jan 21, 2025
@alexs-mparticle
refactor: Create Interfaces for Events (#962)
8a3e61f
alexs-mparticle added a commit that referenced this pull request Jan 21, 2025
@alexs-mparticle
refactor: Create Interfaces for Events (#962)
c8340c3
alexs-mparticle added a commit that referenced this pull request Jan 27, 2025
@alexs-mparticle
refactor: Create Interfaces for Events (#962)
9691517
alexs-mparticle added a commit that referenced this pull request Feb 3, 2025
@alexs-mparticle
refactor: Create Interfaces for Events (#962)
1eeb01f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexs-mparticle @rmi22186