Skip to content

Conversation

@BrandonStalnaker
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker commented Dec 11, 2025

Background

  • Investigation found that the mapped userAttributes were being set on the user but when the user is retrieved an forwarded on the kit level the new attributes were not present and since we use user attributes over the passed in attributes it wasn’t being forwarded to rokt correctly. This will be paired to a rokt kit changes to resolve the issue.
  • We also decided to add idfa and idfv properties to the FilteredMParticleUser so that this data would be available to rokt (assuming customer allows)

What Has Changed

  • Kit configuration values (placementAttributesMapping, hashedEmailUserIdentityType) were being accessed at the wrong nesting level
  • Now correctly accesses values through roktKitConfig["as"][key] instead of roktKitConfig[key]
  • Added kMPRemoteConfigKitConfigurationKey constant (@"as")
  • Added nil check before NSNull check to prevent crashes
  • Replaced 6 NSLog calls with MPILogVerbose for consistent SDK logging
  • Added exception logging to previously empty @catch block
  • Updated existing testGetRoktPlacementAttributesMapping config structure
  • Added testGetRoktHashedEmailUserIdentityType
  • Added testGetRoktHashedEmailUserIdentityTypeReturnsNilWhenNotConfigured
  • Added idfa and idfv properties to FilteredMParticleUser
  • Also included a fix for our CI tests so they would run as expected

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Dec 11, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner December 11, 2025 20:45
thomson-t
thomson-t previously approved these changes Dec 11, 2025
@BrandonStalnaker BrandonStalnaker changed the base branch from blackout/Phase-1 to main December 12, 2025 19:17
@BrandonStalnaker BrandonStalnaker force-pushed the fix/SDKE-692-Rokt-User-Attribute-Mapping-Fix branch from 3b01bfa to 6803814 Compare December 12, 2025 19:18
@BrandonStalnaker BrandonStalnaker force-pushed the fix/SDKE-692-Rokt-User-Attribute-Mapping-Fix branch from 6803814 to 10fdb68 Compare December 12, 2025 19:34
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit

Co-authored-by: Nickolas Dimitrakas <nickolas.dimitrakas@rokt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants