fix: migrate all generic logs to Logger class

.github/workflows/pull-request.yml

@@ -12,6 +12,7 @@ permissions:
   checks: write
   id-token: write
 
+jobs:
   # Code quality checks
   trunk-check:
     name: Trunk code check
@@ -22,9 +23,7 @@ permissions:
       - name: Trunk Check
         uses: trunk-io/trunk-action@75699af9e26881e564e9d832ef7dc3af25ec031b # v1.2.4
         with:
-          check-mode: all
-
-jobs:
+          check-mode: pull_request
   pr-check-hadcoded-secrets:
     name: "Check PR for hardcoded secrets"
     uses: mParticle/mparticle-workflows/.github/workflows/security-hardcoded-secrets.yml@main

android-core/src/androidTest/java/com/mparticle/internal/MParticleJSInterfaceITest.java

@@ -233,7 +233,7 @@ public void setUserAttribute(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException jse) {
-                    jse.printStackTrace();
+                    Logger.error(jse);
                 }
 
             }
@@ -259,7 +259,7 @@ public void removeUserAttribute(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException jse) {
-                    jse.printStackTrace();
+                    Logger.error(jse);
                 }
             }
         });
@@ -285,7 +285,7 @@ public void setUserTag(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException jse) {
-                    jse.printStackTrace();
+                    Logger.error(jse);
                 }
             }
 
@@ -300,7 +300,7 @@ public void setUserAttribute(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException jse) {
-                    jse.printStackTrace();
+                    Logger.error(jse);
                 }
             }
         });
@@ -357,7 +357,7 @@ public void logEvent(String json) {
                     }
                     Logger.error(new JSONObject(json).toString(4));
                 } catch (JSONException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });
@@ -466,7 +466,7 @@ public void logout(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });
@@ -518,7 +518,7 @@ public void login(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });
@@ -570,7 +570,7 @@ public void modify(String json) {
                     called.value = true;
                     latch.countDown();
                 } catch (JSONException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });

android-core/src/androidTest/kotlin/com.mparticle/PushRegistrationTest.kt

@@ -2,6 +2,7 @@ package com.mparticle
 
 import android.content.Context
 import com.mparticle.internal.ConfigManager
+import com.mparticle.internal.Logger
 import com.mparticle.internal.PushRegistrationHelper
 import com.mparticle.internal.PushRegistrationHelper.PushRegistration
 import com.mparticle.networking.Matcher
@@ -209,7 +210,7 @@ class PushRegistrationTest : BaseCleanStartedEachTest() {
                         try {
                             Thread.sleep(10)
                         } catch (e: InterruptedException) {
-                            e.printStackTrace()
+                            Logger.error(e)
                         }
                     }
                     TestingUtils.setFirebasePresent(false, null)

android-core/src/androidTest/kotlin/com.mparticle/SessionMessagesTest.kt

@@ -5,6 +5,7 @@ import android.os.Looper
 import com.mparticle.internal.AccessUtils
 import com.mparticle.internal.AppStateManager
 import com.mparticle.internal.Constants
+import com.mparticle.internal.Logger
 import com.mparticle.networking.Matcher
 import com.mparticle.networking.MockServer.JSONMatch
 import com.mparticle.testutils.AndroidUtils
@@ -61,7 +62,7 @@ sent sessionId = ${eventObject.getString("id")}""",
                             }
                         }
                     } catch (e: Exception) {
-                        e.printStackTrace()
+                        Logger.error(e)
                         Assert.fail(e.message)
                     }
                     false

android-core/src/androidTest/kotlin/com.mparticle/UploadMessageTest.kt

@@ -5,6 +5,7 @@ import android.os.Looper
 import com.mparticle.internal.AccessUtils
 import com.mparticle.internal.AccessUtils.EmptyMParticleApiClient
 import com.mparticle.internal.Constants
+import com.mparticle.internal.Logger
 import com.mparticle.internal.MPUtility
 import com.mparticle.internal.MParticleApiClientImpl.MPRampException
 import com.mparticle.internal.MParticleApiClientImpl.MPThrottleException
@@ -86,7 +87,7 @@ class UploadMessageTest : BaseCleanStartedEachTest() {
                                 }
                             }
                         } catch (e: Exception) {
-                            e.printStackTrace()
+                            Logger.error(e)
                             Assert.fail(e.toString())
                         }
                     }

android-core/src/androidTest/kotlin/com.mparticle/identity/IdentityApiTest.kt

@@ -6,6 +6,7 @@ import android.os.Looper
 import com.mparticle.MParticle
 import com.mparticle.MParticle.IdentityType
 import com.mparticle.internal.ConfigManager
+import com.mparticle.internal.Logger
 import com.mparticle.networking.Matcher
 import com.mparticle.testutils.AndroidUtils
 import com.mparticle.testutils.BaseCleanStartedEachTest
@@ -64,7 +65,7 @@ class IdentityApiTest : BaseCleanStartedEachTest() {
                     com.mparticle.internal.AccessUtils
                         .awaitMessageHandler()
                 } catch (e: InterruptedException) {
-                    e.printStackTrace()
+                    Logger.error(e)
                 }
                 assertMParticleUserEquals(user, mpid1, identities, null, isLoggedIn)
                 latch.countDown()

android-core/src/androidTest/kotlin/com.mparticle/identity/MParticleIdentityClientImplTest.kt

@@ -4,6 +4,7 @@ import android.os.Handler
 import android.util.MutableBoolean
 import com.mparticle.MParticle
 import com.mparticle.internal.ConfigManager
+import com.mparticle.internal.Logger
 import com.mparticle.internal.MPUtility
 import com.mparticle.networking.MPConnection
 import com.mparticle.networking.MPConnectionTestImpl
@@ -323,7 +324,7 @@ class MParticleIdentityClientImplTest : BaseCleanStartedEachTest() {
                     try {
                         identityClient?.makeUrlRequest(connection, payload, identity)
                     } catch (e: JSONException) {
-                        e.printStackTrace()
+                        Logger.error(e)
                         Assert.fail(e.message)
                     }
                     (connection as MPConnectionTestImpl).responseCode = 202

android-core/src/androidTest/kotlin/com.mparticle/internal/AppStateManagerInstrumentedTest.kt

@@ -57,7 +57,7 @@ class AppStateManagerInstrumentedTest : BaseCleanStartedEachTest() {
                         }
                         checked[0] = true
                     } catch (e: JSONException) {
-                        e.printStackTrace()
+                        Logger.error(e)
                     }
                 }
             },
@@ -97,7 +97,7 @@ class AppStateManagerInstrumentedTest : BaseCleanStartedEachTest() {
                             latch.countDown()
                         }
                     } catch (e: JSONException) {
-                        e.printStackTrace()
+                        Logger.error(e)
                     }
                 }
             },

android-core/src/androidTest/kotlin/com.mparticle/internal/database/services/ReportingServiceTest.kt

@@ -2,6 +2,7 @@ package com.mparticle.internal.database.services
 
 import com.mparticle.internal.Constants
 import com.mparticle.internal.JsonReportingMessage
+import com.mparticle.internal.Logger
 import com.mparticle.testutils.TestingUtils
 import org.json.JSONException
 import org.junit.Assert
@@ -213,7 +214,7 @@ class ReportingServiceTest : BaseMPServiceTest() {
                         .getInt("a random Number")
                         .compareTo(o2.msgObject.getInt("a random Number"))
                 } catch (e: JSONException) {
-                    e.printStackTrace()
+                    Logger.error(e)
                 }
                 -1
             },
@@ -227,7 +228,7 @@ class ReportingServiceTest : BaseMPServiceTest() {
                         .getInt("a random Number")
                         .compareTo(o2.toJson().getInt("a random Number"))
                 } catch (e: JSONException) {
-                    e.printStackTrace()
+                    Logger.error(e)
                 }
                 -1
             },

android-core/src/androidTest/kotlin/com.mparticle/networking/PinningTestHelper.kt

@@ -7,6 +7,7 @@ import com.mparticle.MParticle
 import com.mparticle.identity.MParticleIdentityClient
 import com.mparticle.internal.AccessUtils
 import com.mparticle.internal.Constants
+import com.mparticle.internal.Logger
 import com.mparticle.internal.MParticleApiClient
 import com.mparticle.internal.MParticleApiClientImpl
 import com.mparticle.internal.MParticleApiClientImpl.MPNoConfigException
@@ -43,9 +44,9 @@ class PinningTestHelper internal constructor(
                 ),
             )
         } catch (e: MalformedURLException) {
-            e.printStackTrace()
+            Logger.error(e)
         } catch (e: MPNoConfigException) {
-            e.printStackTrace()
+            Logger.error(e)
         }
         val apiClient: MParticleApiClient = AccessUtils.getApiClient()
         setRequestClient(apiClient, path)

android-core/src/main/java/com/mparticle/MPReceiver.java

@@ -8,6 +8,7 @@
 
 import androidx.annotation.NonNull;
 
+import com.mparticle.internal.Logger;
 import com.mparticle.messaging.MPMessagingAPI;
 import com.mparticle.messaging.ProviderCloudMessage;
 
@@ -62,7 +63,7 @@ public void run() {
                 try {
                     Class.forName("android.os.AsyncTask");
                 } catch (ClassNotFoundException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });

android-core/src/main/java/com/mparticle/MPServiceUtil.java

@@ -45,7 +45,7 @@ public void run() {
                 try {
                     Class.forName("android.os.AsyncTask");
                 } catch (ClassNotFoundException e) {
-                    e.printStackTrace();
+                    Logger.error(e);
                 }
             }
         });

android-core/src/main/java/com/mparticle/internal/ConfigManager.java

@@ -370,7 +370,7 @@ public synchronized void configUpToDate() throws JSONException {
                 onConfigLoaded(ConfigType.KIT, kitConfig != combined);
             }
         } catch (JSONException e) {
-            e.printStackTrace();
+            Logger.error(e);
             throw new RuntimeException(e);
         }
     }

android-core/src/main/java/com/mparticle/internal/MPUtility.java

@@ -811,13 +811,13 @@ public static String getProp(String key) {
             Method get = SystemProperties.getMethod("get", new Class[]{String.class});
             return get.invoke(SystemProperties, new Object[]{key}).toString();
         } catch (ClassNotFoundException e) {
-            e.printStackTrace();
+            Logger.error(e);
         } catch (NoSuchMethodException e) {
-            e.printStackTrace();
+            Logger.error(e);
         } catch (IllegalAccessException e) {
-            e.printStackTrace();
+            Logger.error(e);
         } catch (InvocationTargetException e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
         return null;
     }

android-core/src/main/java/com/mparticle/internal/database/tables/MParticleDatabaseHelper.java

@@ -159,7 +159,7 @@ private void removeGcmTable(SQLiteDatabase db) {
         try {
             db.execSQL("DROP TABLE IF EXISTS gcm_messages");
         } catch (Exception e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
     }
 

android-core/src/main/java/com/mparticle/internal/messages/BaseMPMessageBuilder.java

@@ -7,6 +7,7 @@
 
 import com.mparticle.internal.Constants;
 import com.mparticle.internal.InternalSession;
+import com.mparticle.internal.Logger;
 
 import org.json.JSONArray;
 import org.json.JSONException;
@@ -24,15 +25,15 @@ public BaseMPMessageBuilder(String messageType) {
         try {
             put(Constants.MessageKey.TYPE, messageType);
         } catch (JSONException e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
     }
 
     public BaseMPMessageBuilder timestamp(long timestamp) {
         try {
             put(Constants.MessageKey.TIMESTAMP, timestamp);
         } catch (JSONException e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
         return this;
     }
@@ -50,7 +51,7 @@ public BaseMPMessageBuilder name(String name) {
         try {
             put(Constants.MessageKey.NAME, name);
         } catch (JSONException e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
         return this;
     }
@@ -63,7 +64,7 @@ public BaseMPMessageBuilder attributes(JSONObject attributes) {
                     addEventLengthAttributes(mLength);
                 }
             } catch (JSONException e) {
-                e.printStackTrace();
+                Logger.error(e);
             }
         }
         return this;
@@ -82,7 +83,7 @@ public BaseMPMessageBuilder dataConnection(String dataConnection) {
             try {
                 put(Constants.MessageKey.STATE_INFO_DATA_CONNECTION, dataConnection);
             } catch (JSONException e) {
-                e.printStackTrace();
+                Logger.error(e);
             }
         }
         return this;
@@ -95,7 +96,7 @@ public BaseMPMessageBuilder length(Double length) {
                 put(Constants.MessageKey.EVENT_DURATION, length);
                 addEventLengthAttributes(length);
             } catch (JSONException e) {
-                e.printStackTrace();
+                Logger.error(e);
             }
         }
         return this;
@@ -111,7 +112,7 @@ private void addEventLengthAttributes(Double length) {
                 getJSONObject(Constants.MessageKey.ATTRIBUTES).put("EventLength", Integer.toString(length.intValue()));
             }
         } catch (JSONException e) {
-            e.printStackTrace();
+            Logger.error(e);
         }
     }
 
@@ -127,7 +128,7 @@ public BaseMPMessageBuilder flags(Map<String, List<String>> customFlags) {
                 }
                 put(Constants.MessageKey.EVENT_FLAGS, flagsObject);
             } catch (JSONException e) {
-                e.printStackTrace();
+                Logger.error(e);
             }
         }
         return this;

android-core/src/main/java/com/mparticle/internal/messages/MPEventMessage.java

@@ -7,6 +7,7 @@
 import com.mparticle.MParticle;
 import com.mparticle.internal.Constants;
 import com.mparticle.internal.InternalSession;
+import com.mparticle.internal.Logger;
 
 import org.json.JSONException;
 
@@ -26,7 +27,7 @@ public BaseMPMessageBuilder customEventType(MParticle.EventType eventType) {
             try {
                 put(Constants.MessageKey.EVENT_TYPE, eventType);
             } catch (JSONException e) {
-                e.printStackTrace();
+                Logger.error(e);
             }
             return this;
         }