-
Notifications
You must be signed in to change notification settings - Fork 7
fix: adjust ad break exclusion logic #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the changelog and Readme as well?
|
I think the following test makes sense to ensure user pausing and ad break ending is correctly ensuring contentTime is calculated and excluding ad breaks. The scenario is let's say you are watching a youtube video and mid ad, a user pauses, then the ad break ends (perhaps the "skip" button is shown and the user clicks it, creating an ad break end). |
rmi22186
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments
|
## [1.7.0](v1.6.0...v1.7.0) (2025-12-12) ### Features * Update Media Content Time Spent Calculations with Ad Breaks ([#74](#74)) ([c455557](c455557)) ### Bug Fixes * adjust ad break exclusion logic ([#76](#76)) ([84b1493](84b1493)) ### Updates & Maintenance * Migrate from OSSRH to Central Publishing Portal ([#75](#75)) ([ac8de37](ac8de37))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |



Instructions
Summary
Updated boolean flag usage for clarity.
Test cases modified to remove flaky timing assertions and ensure correctness.
Testing Plan
Reference Issue