Skip to content

feat: Calculate mediaTimeSpent based on current time #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mansi-mParticle merged 1 commit into from
Jun 27, 2025
Merged

feat: Calculate mediaTimeSpent based on current time #73

Mansi-mParticle merged 1 commit into from
Jun 27, 2025

Conversation

@mmustafa-tse
Copy link
Contributor

@mmustafa-tse mmustafa-tse commented Jun 24, 2025

Summary

  • A customer noticed that the getter for mediaTimeSpent calculates the value based on the difference between mediaSessionEndTimestamp and mediaSessionStartTimestamp, which leads to inaccuracy since mediaSessionEndTimestamp is only updated when logging a media event, with this PR it now calculates based on on the difference between System.currentTimeMillis() (current time) and mediaSessionStartTimestamp

Testing Plan

  • E2E and unit tested

Reference Issue

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Mansi-mParticle
Mansi-mParticle approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle merged commit 5f589f0 into mParticle:main Jun 27, 2025
4 checks passed
mparticle-automation added a commit that referenced this pull request Jun 27, 2025
@mparticle-automation
chore: 1.6.0 (release)
198019b 
## [1.6.0](v1.5.6...v1.6.0) (2025-06-27)

### Features

* Calculate mediaTimeSpent based on current time ([#73](#73)) ([5f589f0](5f589f0))
@mparticle-automation
Copy link
Collaborator

mparticle-automation commented Jun 27, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mansi-mParticle Mansi-mParticle Mansi-mParticle approved these changes

@BrandonStalnaker BrandonStalnaker Awaiting requested review from BrandonStalnaker

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmustafa-tse @mparticle-automation @Mansi-mParticle