Add allowNative system properties as switch #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhenry
reviewed
Dec 15, 2025
luhenry
approved these changes
Dec 15, 2025
pan3793
commented
Dec 16, 2025
|
|
||
| final class InstanceBuilder { | ||
|
|
||
| public static final String ALLOW_NATIVE_ARPACK = "dev.ludovic.netlib.arpack.allowNative"; |
Author
There was a problem hiding this comment.
after second thought, maybe it's better to define it at interface LAPACK instead of here, since it is kind of a public API, @luhenry what do you think?
Author
|
kindly ping @luhenry, could you please take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add the following 3 Java system properties as a switch so that the user can control whether
ARPACK.getInstance(),BLAS.getInstance(), andLAPACK.getInstance()prefer to return the native implementation.Sometimes the shared cluster(e.g., Apache Hadoop YARN) host installs very old or bugly OpenBLAS/MKL libs, for Apache Spark jobs, it does not have a switch to disable using that for a single job. With this patch, it's able to pass those system properties so that the user can prefer using the Java implementation without touching the OS libs.