-
Notifications
You must be signed in to change notification settings - Fork 11
Random character #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Random character #34
Conversation
|
I tested it and it works properly, and it was really not that difficult to make. The reason why there's so many commits it's because my main branch was messed up, but I cleaned it and now it only contains the necessary files. |
|
Thanks for submitting this. What did you test on? |
I've tested this on Windows 11, compiled in Visual Studio 2019. I'll see what I can do about what you reviewed and I'll let you know once I've finished |
|
I've managed to come with an easy solution: Global.h Loader.cpp |
|
I took a deeper look at this, and I think this might break the bluetooth p2p mode. Since it sends the character code during character selection, it doesn't resolve to the actual character code before sending. This means that it'll get loaded as a random character on both devices, and most likely as a different character |
|
I think if you want to implement random, you're probably better off having it auto-select a random character when you activate the character preview at the bottom. Or if you don't want to know what character its selected when you choose random, you can add an extra boolean to hide the selected character if its currently randomized. This might be more complicated though. Edit: didn't mean to close it, sorry about that |
Adds a random character option to the CSS just like official Smash games do.