lib/misc.c: fix build against -std=c23 (void (*)()) changed the mea…
#327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning)
gcc-15 switched to -std=c23 by default:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212
As a result `lsof` fails the build as:
misc.c:390:26: error: too many arguments to function 'r_fn'
390 | rv = r_fn(r_arg, r.r_rbuf, r_rbln);
| ^~~~
Before C23 `int (*)()` meant any function that returns `int`. In `C23`
if means only `int (*)(void)`. But `lsof` alwaus uses
`int (*)(char *path, char *buf, int len)` in that place. Switched to
explicit function type instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ning)
gcc-15 switched to -std=c23 by default:
As a result
lsoffails the build as:Before C23
int (*)()meant any function that returnsint. InC23if means onlyint (*)(void). Butlsofalwaus usesint (*)(char *path, char *buf, int len)in that place. Switched to explicit function type instead.