Skip to content

Fix domain #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmgle wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix domain #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e37255
remove trailing spaces
hmgle Mar 2, 2015
27eafb4
fix #2: replace 'netloc' to 'hostname'
hmgle Mar 2, 2015
81f0075
add example
hmgle Mar 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions parse_domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,35 @@ def parse_domain(url, levels=2):
"""
if levels < 1 or not url:
return None

# Parse the hostname from the url
parsed = urlparse(url)
hostname = getattr(parsed,'netloc',url)
hostname = getattr(parsed,'hostname',url)

partial_domains = []
partial_domain = ""
if hostname is None:
return None
for section in reversed(hostname.split(".")):
partial_domain = "." + section + partial_domain
partial_domains.append(partial_domain)

# Find the longest matching TLD, recording its index
tld_idx = 0
for idx, item in enumerate(partial_domains):
if item in tlds:
tld_idx = idx

# Add the desired number of levels to the tld index,
# counting the TLD itself as the first level
try:
domain = partial_domains[tld_idx + levels - 1]
except IndexError:
domain = partial_domains[-1]

# Remove the initial dot
return domain[1:]

tlds = set((
'.2000.hu',
'.ab.ca',
Expand Down Expand Up @@ -1576,7 +1578,7 @@ def parse_domain(url, levels=2):


if __name__=="__main__":
for item in ['http://something.unknown','http://a.b.c.something.unknown','http://something','http://google.com','http://a.b.c.d.e.google.com','http://something.uk','http://aa.bb.cc.dd.ee.ff.gg.guardian.co.uk','http://guardian.co.uk','http://www.guardian.co.uk','http://www.google.com','http://wikipedia.org','http://www.wikipedia.org','',None,'whatever']:
for item in ['http://something.unknown','http://a.b.c.something.unknown','http://something','http://google.com','http://a.b.c.d.e.google.com','http://something.uk','http://aa.bb.cc.dd.ee.ff.gg.guardian.co.uk','http://guardian.co.uk','http://www.guardian.co.uk','http://www.google.com','http://wikipedia.org','http://www.wikipedia.org','http://www.example.com:1234','',None,'whatever']:
for level in range(0,5):
print "url=%s, levels=%s => %s" % (item, level, parse_domain(item,level))

Expand Down