Skip to content

Harden websocket client error handling #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zxch3n merged 1 commit into from
Dec 11, 2025
Merged

Harden websocket client error handling #41

zxch3n merged 1 commit into from
Dec 11, 2025

Conversation

@zxch3n
Copy link
Member

@zxch3n zxch3n commented Dec 11, 2025

  • add onError hook and safeSend guard to avoid sending on closed sockets
  • swallow decode/socket errors without crashing and surface via onError
  • cover join retry + decode failure with tests

Tests: pnpm --filter loro-websocket test; pnpm --filter loro-adaptors test; pnpm test

@zxch3n zxch3n merged commit 858a1e9 into main Dec 11, 2025
2 checks passed
@zxch3n zxch3n deleted the zxch3n/ws-client-robustness branch December 11, 2025 16:12
@github-actions github-actions bot mentioned this pull request Dec 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxch3n