[Feature] Implement false positive selection in DonPAPI #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added false positive cli argument. Fixed typo in variable name 'false_positivee'. Actually sending the false positive list to DonPAPICore class.
Author
|
@login-securite @zblurx please let me know if I need to do anything else to merge this feature... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously mentioned on my other issue - I sought a way to allow users of DonPAPI to achieve a more custom filtration method of results.
This change is not only a "nice to have" feature, but a massive performance enhancer for big tasks.
As we approach larger scale networks with more users and more computers, the collection becomes a very long task - much more prone to crashes & errors.
If we manage to limit the amount of time we spend on each collection, we can massively improve the performance & collection times of our triage.
These changes were achieved due to my previous contribution to the DPLoot Project which allowed me to implement these necessary features.
Big thanks to @zblurx for the cooperation and support!
I hope this feature helps others achieve better performance out of DonPAPI!