Skip to content

Conversation

@sschulz92
Copy link
Contributor

Following actions were made:

  • Add @Override automatically
  • Apply code-formatter
  • Remove unnecessary javadoc
  • Remove curly-braces for switch-case
  • Fix possible NullPointerException in ProjectImpl.java

public void notifyChanged(Notification msg) {
switch (msg.getFeatureID(RenderManager.class)) {
case RenderPackage.RENDER_MANAGER__VIEWPORT_MODEL_INTERNAL: {
case RenderPackage.RENDER_MANAGER__VIEWPORT_MODEL_INTERNAL:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO the code looks much better but since it is a generated file I assume:

  • its reset after generation from EMF model again
  • its worth to find a way how the right formatter is applied after code-generation

I'd like to avoid efford the might be useless ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I find the information which class is generated? Is there any documentation I may read regarding EMF?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants