Fix wtr-lab #1942
Draft
Fix wtr-lab #1942
+235
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Uncertain if I want to put in the work for the other searches- and uncertain if I'll succeed if I do. Marked them as TODOs. Edit: Ugh. Even after fixing the two bugs below, web translation works in dev but not on the app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1689
Fixes #1535
Fixes #1498
Fixes #1495
Issues:
Broken novel parsing
Broken ToC parsing - Separate json request instead of in source used now
Broken chapter parsing
Searches repeating
Web translation wasn't available
Solutions:
Fixed novel parsing
Added ToC json request
Use new chapter API
Told searches not to repeat
Fallback to web translation
Known Problems/TODO:
Using inferior search (Other one is complex, later problem)
Using inferior latest (Same as above)
Should add/verify search filters
Web translation works in dev but not on app?