Skip to content

[CI] Tweak wording for builds with passing tests and build errors #171436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidSpickett merged 1 commit into from
Dec 9, 2025
Merged

[CI] Tweak wording for builds with passing tests and build errors #171436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/generate_test_report_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def plural(num_tests):
report.extend(
[
"",
"All tests passed but another part of the build **failed**. "
"All executed tests passed, but another part of the build **failed**. "
"Information about the build failure could not be automatically "
"obtained.",
"",
Expand All @@ -278,7 +278,7 @@ def plural(num_tests):
report.extend(
[
"",
"All tests passed but another part of the build **failed**. Click on "
"All executed tests passed, but another part of the build **failed**. Click on "
"a failure below to see the details.",
"",
]
Expand Down
8 changes: 4 additions & 4 deletions .ci/generate_test_report_lib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def test_no_failures_build_failed(self):

* 1 test passed

All tests passed but another part of the build **failed**. Information about the build failure could not be automatically obtained.
All executed tests passed, but another part of the build **failed**. Information about the build failure could not be automatically obtained.

Download the build's log file to see the details.

Expand Down Expand Up @@ -390,7 +390,7 @@ def test_no_failures_build_failed_ninja_log(self):

* 1 test passed

All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>test/4.stamp</summary>
Expand Down Expand Up @@ -476,7 +476,7 @@ def test_no_failures_multiple_build_failed_ninja_log(self):

* 1 test passed

All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>touch test/2.stamp</summary>
Expand Down Expand Up @@ -978,7 +978,7 @@ def test_generate_report_end_to_end(self):

* 1 test passed

All tests passed but another part of the build **failed**. Click on a failure below to see the details.
All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>test/4.stamp</summary>
Expand Down