Skip to content

[mlir][memref] Support ignoring ValueRange in foldMemrefCast #171337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shay-kl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[mlir][memref] Support ignoring ValueRange in foldMemrefCast #171337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff573c
[mlir][memref] Support ignoring ValueRange in foldMemrefCast
Dec 9, 2025
8b1c0d9
Merge branch 'main' into memref/improve_cast_fold
shay-kl Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mlir/include/mlir/Dialect/MemRef/IR/MemRef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ namespace memref {

/// This is a common utility used for patterns of the form
/// "someop(memref.cast) -> someop". It folds the source of any memref.cast
/// into the root operation directly.
LogicalResult foldMemRefCast(Operation *op, Value inner = nullptr);
/// into the root operation directly. Operands in `ignoredOperands` are excluded
/// from folding.
LogicalResult foldMemRefCast(Operation *op, ValueRange ignoredOperands = {});

/// Return an unranked/ranked tensor type for the given unranked/ranked memref
/// type.
Expand Down
8 changes: 5 additions & 3 deletions mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ Operation *MemRefDialect::materializeConstant(OpBuilder &builder,

/// This is a common class used for patterns of the form
/// "someop(memrefcast) -> someop". It folds the source of any memref.cast
/// into the root operation directly.
LogicalResult mlir::memref::foldMemRefCast(Operation *op, Value inner) {
/// into the root operation directly. Operands in `ignoredOperands` are excluded
/// from folding.
LogicalResult mlir::memref::foldMemRefCast(Operation *op,
ValueRange ignoredOperands) {
bool folded = false;
for (OpOperand &operand : op->getOpOperands()) {
auto cast = operand.get().getDefiningOp<CastOp>();
if (cast && operand.get() != inner &&
if (cast && !llvm::is_contained(ignoredOperands, operand.get()) &&
!llvm::isa<UnrankedMemRefType>(cast.getOperand().getType())) {
operand.set(cast.getOperand());
folded = true;
Expand Down