Skip to content

feat: Add annotations to ingress and improve monitoring #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alisson276 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Add annotations to ingress and improve monitoring #120

alisson276 wants to merge 4 commits into from

Conversation

@alisson276
Copy link

@alisson276 alisson276 commented Jan 28, 2025 •
edited
Loading

Features added:

  • Add annotations to ingress, so you are able to use alb-controller annotations
  • Make Whip protocol optional, so is not created onto the load balancer
  • Added ServiceMonitor for ingress and PodMonitor for egress, so Prometheus can discover them and scrape metrics automatically
  • Fixed an issue when using livekit.prometheus.port instead of livekit.prometheus_port (deprecation warning)

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alisson276 alisson276 changed the title feat: Add annotations to ingress feat: Add annotations to ingress and improve monitoring Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alisson276 @CLAassistant