Pull upstream changes from commerce_promotion #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
reviewed
Jan 3, 2020
| /** | ||
| * Allows fee start and end dates to have a time component. | ||
| */ | ||
| function commerce_fee_post_update_1(array &$sandbox = NULL) { |
There was a problem hiding this comment.
We shouldn't need this, since it's a "new" module." But I guess some may have had this installed before
Author
There was a problem hiding this comment.
I'll be happy to remove it if you give me the word. It came in handy for me because I had already installed the broken version in another environment, but now that the update has run I don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for
CommerceContentEntityStoragechanged, andPromotionStorage::loadAvailable()got some date improvements.Link to Drupal.org issue: https://www.drupal.org/project/commerce/issues/2903716