Add option to remove (common) ansi escape codes from on_write #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionkor
force-pushed
the
ansi-escape-removal
branch
from
49fad8f to
02a8c46
Compare
lionkor
force-pushed
the
ansi-escape-removal
branch
from
02a8c46 to
47a2d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users of the library use
\x1b[1;2mto make their output colorful, they end up with all of the extra control characters in their log if they useon_writeas a logging mechanism.This PR adds
enable_ansi_escape_removal_on_write, which attempts to filter most/all of the ANSI escape codes it can find out of the output. This results in more allocations, but should be a minimal impact on normal use performance of this library.