Add external/virtual tree path tests for improved coverage #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split tests to avoid exceeding file size limit: - doublets/tests/store_internals.rs: Original tests (827 lines) - doublets/tests/external_tree_tests.rs: New tests (436 lines) New tests (17 tests in external_tree_tests.rs): | Test Name | Purpose | |-----------|---------| | `split_virtual_source_operations` | Test virtual source handling | | `split_external_source_tree_iteration` | Test tree iteration with handler | | `split_virtual_target_operations` | Test virtual target handling | | `split_search_all_tree_paths` | Test search across tree branches | | `split_count_usages_tree_branches` | Test count_usages tree traversal | | `split_tree_ordering_operations` | Test tree ordering comparisons | | `split_each_usages_core_branches` | Test recursive iteration | | `unit_virtual_source_operations` | Unit store virtual source tests | | `unit_tree_ordering_operations` | Unit store ordering tests | | `unit_each_usages_core_branches` | Unit store iteration tests | | `split_count_links_two_element_query` | Test 2-element query counting | | `split_is_virtual_detection` | Test is_unused detection | | `split_resolve_dangling_operations` | Test dangling link resolution | 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
force-pushed
the
add-external-tree-tests
branch
from
4af3a0a to
ff8a1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional tests following the merge of #45, focusing on external (virtual) source/target tree code paths.
New Tests (17 tests)
split_virtual_source_operationssplit_external_source_tree_iterationsplit_virtual_target_operationssplit_search_all_tree_pathssplit_count_usages_tree_branchessplit_tree_ordering_operationssplit_each_usages_core_branchesunit_virtual_source_operationsunit_tree_ordering_operationsunit_each_usages_core_branchessplit_count_links_two_element_querysplit_is_virtual_detectionsplit_resolve_dangling_operationsContext
These tests exercise internal tree operations that handle "virtual" or "external" links - cases where a link references a source or target that has been deleted. This is important for testing the split store's external source/target trees.
Follows up on #45 and issue #44.
Test Plan
cargo test --all-features🤖 Generated with Claude Code