Add tests for nullable numeric types CanBeNumeric property #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
int?,double?,bool?) to verify they are correctly marked asCanBeNumericNumericType<T>class properly extracts the underlying type for nullable types and checks if that type can be numericTest plan
NumericTypeTests.csint?,double?, etc.) returnCanBeNumeric: Truestring?) returnCanBeNumeric: FalseAnalysis
The issue was already resolved in the current implementation. The
NumericType<T>constructor correctly:type.IsNullable()Nullable.GetUnderlyingType(type)underlyingType.CanBeNumeric()This means
int?becomesint,double?becomesdouble, and so on, and since these underlying types are numeric, the nullable versions are correctly marked asCanBeNumeric.Fixes #22
🤖 Generated with Claude Code