Resolve meaning conflicts for null restrictions in ILinks interface #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #37
Fix ambiguous documentation for null restrictions across all ILinks methods: - **Count**: Clarify null restriction returns 0 (safe behavior) - **Each**: Specify null restriction processes no links (safe behavior) - **Create**: Define null substitution creates a point (self-referencing link) - **Update**: Establish null restriction updates no links (safer default) - **Delete**: Emphasize null restriction deletes NO links (critical safety measure) Key improvements: - Replace ambiguous "no restriction" with explicit "null = safe default" - Distinguish between null (safe, matches nothing) and Constants.Any (matches everything) - Add safety warnings for Delete operations to prevent accidental data loss - Ensure consistent behavior interpretation across all operations - Update Russian translations to match new semantics This resolves the semantic ambiguity where null restrictions could be interpreted as either "any link" or "no link", establishing the safer "no link" interpretation as standard behavior. Fixes #37 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the semantic ambiguity in the ILinks interface where null restrictions could be interpreted as either "any link" or "no link", as reported in issue #37.
Changes Made
Documentation Clarifications:
Key Safety Improvements:
null(safe, matches nothing) andConstants.Any(matches everything)Rationale
The previous ambiguity was dangerous, especially for Delete operations where
nullcould potentially be interpreted as "delete all links". This PR establishes the safer interpretation wherenullmeans "match nothing" as the standard behavior.To explicitly match all links, developers must use
Constants.Anyin restriction arrays, making the intent clear and preventing accidental destructive operations.Test Results
All existing tests pass, confirming backward compatibility with current implementations.
Test plan
Fixes #37
🤖 Generated with Claude Code