Skip to content

Rename Size property to Count to reduce number of properties #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename Size property to Count to reduce number of properties #165

konard wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 13, 2025 •
edited
Loading

Summary

This PR addresses issue #63 by removing the redundant Size property from the Point<TLinkAddress> class and consolidating it with the existing Count property.

Changes made:

  • ✅ Removed the Size property declaration
  • ✅ Updated the Count property to be a direct property instead of returning Size
  • ✅ Changed constructor parameter from size to count for consistency
  • ✅ Updated all internal references from Size to Count in:
    • Indexer bounds checking
    • For loops in GetEnumerator() methods
    • Constructor assignment

Benefits:

  • Reduced complexity: Eliminates redundant property, reducing the total number of properties in the class
  • Improved clarity: Single property Count is more intuitive and aligns with standard .NET collection interfaces
  • Better maintainability: Less code to maintain and fewer potential inconsistencies

Test plan

  • ✅ All existing tests pass (3/3 tests successful)
  • ✅ Code builds successfully without compilation errors
  • ✅ Verified no external dependencies on the Size property exist in the codebase

Fixes #63

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #63
95e8d1c 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #63
@konard konard self-assigned this Sep 13, 2025
@konard @claude
Rename Size property to Count to reduce number of properties
450703d 
- Remove redundant Size property in Point<TLinkAddress> class
- Update Count property to be direct property instead of returning Size
- Update constructor parameter from 'size' to 'count'
- Update all internal references from Size to Count
- Fixes issue #63: reducing property count improves code clarity

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] It is possible to rename this property to Count to reduce the number of properties Rename Size property to Count to reduce number of properties Sep 13, 2025
@konard konard marked this pull request as ready for review September 13, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It is possible to rename this property to Count to reduce the number of properties

2 participants

@konard