Make WriteHandlerState.Handler nullable #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #102
Added constructor overload to accept nullptr for Handler parameter, matching the nullable behavior already present in the C# version. This allows creating WriteHandlerState instances with null handlers, which is useful when no handler is needed initially. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nullptrfor Handler parameter in C++ versionWriteHandler<TLinkAddress>? handler)WriteHandlerStateinstances with null handlers when no handler is needed initiallyChanges Made
C++ (
WriteHandlerState.h)WriteHandlerState(typename TStorage::LinkAddressType $continue, typename TStorage::LinkAddressType $break, std::nullptr_t)Handle()method already supports nullable handlersC# (No changes needed)
WriteHandler<TLinkAddress>? handlerparameterTest Plan
Fixes #102
🤖 Generated with Claude Code