Skip to content

Move restrictions before substitution in Update method #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move restrictions before substitution in Update method #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9bb2fe
Initial commit with task details for issue #113
konard Sep 12, 2025
5111329
Add Update method with variadic restrictions to fix parameter order i…
konard Sep 12, 2025
4417434
Remove CLAUDE.md - Claude command completed
konard Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/Platform.Data.Tests/ILinksTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ namespace Platform::Data::Tests
const TLinkAddress linkAddress {1};
Create(storage, linkAddress);
Update(storage, TLink{1}, TLink{1, 1});
Update(storage, TLink{1, 1}, linkAddress); // Test new variadic Update method
storage.Count(TLink{1});
const_links.Count(TLink{1});
storage.Each(TLink{1}, [](const TLink& link){ return 1; });
Expand Down
7 changes: 7 additions & 0 deletions cpp/Platform.Data/ILinksExtensions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@
typename TStorage::LinkType restrictionContainer { static_cast<typename TStorage::LinkAddressType>(restriction)... };
return DIRECT_METHOD_CALL(TStorage, storage, Each, restrictionContainer, handler);
}

template<typename TStorage>
static typename TStorage::LinkAddressType Update(TStorage& storage, const typename TStorage::LinkType& substitution, std::convertible_to<typename TStorage::LinkAddressType> auto... restrictions)
{
typename TStorage::LinkType restrictionContainer { static_cast<typename TStorage::LinkAddressType>(restrictions)... };
return Update(storage, restrictionContainer, substitution);
}

template<typename TStorage>
static typename TStorage::LinkType GetLink(const TStorage& storage, typename TStorage::LinkAddressType linkAddress)
Expand Down
Loading