Skip to content

Make TLink parameter in LinksOptions configurable and reorder template parameters #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make TLink parameter in LinksOptions configurable and reorder template parameters #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d644c7b
Initial commit with task details for issue #116
konard Sep 12, 2025
e394937
Make TLink parameter in LinksOptions configurable and reorder templat…
konard Sep 12, 2025
1923c38
Remove CLAUDE.md - Claude command completed
konard Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/Platform.Data.Tests/ILinksTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
namespace Platform::Data::Tests
{
template<std::integral TLinkAddress = std::uint64_t, LinksConstants<TLinkAddress> VConstants = LinksConstants<TLinkAddress>{true}, typename TLink = std::vector<TLinkAddress>, typename TReadHandler = std::function<TLinkAddress(TLink)>, typename TWriteHandler = std::function<TLinkAddress(TLink, TLink)>>
struct Links : public ILinks<LinksOptions<TLinkAddress, VConstants, TLink,TReadHandler, TWriteHandler>>
template<std::integral TLinkAddress, typename TLink = std::vector<TLinkAddress>, typename TWriteHandler = std::function<TLinkAddress(TLink, TLink)>, typename TReadHandler = std::function<TLinkAddress(TLink)>, LinksConstants<TLinkAddress> VConstants = LinksConstants<TLinkAddress>{true}>
struct Links : public ILinks<LinksOptions<TLinkAddress, TLink, TWriteHandler, TReadHandler, VConstants>>
{
using base = ILinks<LinksOptions<TLinkAddress, VConstants, TLink, TReadHandler, TWriteHandler>>;
using base = ILinks<LinksOptions<TLinkAddress, TLink, TWriteHandler, TReadHandler, VConstants>>;
using typename base::LinkAddressType;
using typename base::LinkType;
using typename base::WriteHandlerType;
Expand Down
2 changes: 1 addition & 1 deletion cpp/Platform.Data/LinksOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace Platform::Data
{

template<std::integral TLinkAddress = std::uint64_t, LinksConstants<TLinkAddress> VConstants = LinksConstants<TLinkAddress>{true}, typename TLink = std::vector<TLinkAddress>, typename TReadHandler = std::function<TLinkAddress(TLink)>, typename TWriteHandler = std::function<TLinkAddress(TLink, TLink)>>
template<std::integral TLinkAddress, typename TLink = std::vector<TLinkAddress>, typename TWriteHandler = std::function<TLinkAddress(TLink, TLink)>, typename TReadHandler = std::function<TLinkAddress(TLink)>, LinksConstants<TLinkAddress> VConstants = LinksConstants<TLinkAddress>{true}>
struct LinksOptions
{
using LinkAddressType = TLinkAddress;
Expand Down
Loading