Refactor LinksConstants to use template type parameters instead of non-type template parameters #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #117
…n-type template parameters - Changed LinksOptions template parameter from `LinksConstants<TLinkAddress> VConstants` to `typename TLinksConstants` - Updated LinksConstantsExtensions functions to use template type parameters - Added LinkAddressType alias to LinksConstants struct for better type support - Updated ILinks to properly handle new LinksConstantsType - Updated test files to use new template pattern This change allows passing LinksConstants as a type (`typename TLinksConstants`) instead of as an instance/value, providing better flexibility and type safety. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 AI-Powered Solution
This pull request implements the solution for issue #117 by refactoring LinksConstants to use template type parameters instead of non-type template parameters.
📋 Issue Reference
Fixes #117
🎯 Overview
Previously, the codebase used non-type template parameters like
LinksConstants<TLinkAddress> VConstants, requiring an instance/value of LinksConstants to be passed as a template parameter. This PR refactors the design to usetypename TLinksConstantsinstead, allowing LinksConstants to be passed as a type parameter.🔧 Implementation Details
Key Changes Made:
LinksOptions.h:
LinksConstants<TLinkAddress> VConstants = LinksConstants<TLinkAddress>{true}totypename TLinksConstants = LinksConstants<TLinkAddress>LinksConstantsTypetype aliasConstantsto usestatic constexpr TLinksConstants Constants{true}LinksConstants.h:
using LinkAddressType = TLinkAddress;for better type support in template contextsLinksConstantsExtensions.h:
LinksConstants<TLinkAddress> VLinksConstantstotypename TLinksConstantstypename TLinksConstants::LinkAddressTypestatic constexpr TLinksConstants constants{true}ILinks.h:
LinksConstantsTypetype alias from LinksOptionsTest Files:
✅ Benefits
typename TLinksConstantsvsVConstants🔄 Migration
The change is designed to be backward compatible. Existing code that was using:
LinksOptions<TLinkAddress, LinksConstants<TLinkAddress>{true}, ...>Can now use:
🧪 Testing
The changes maintain the same interface and behavior. All template instantiations that previously worked continue to work with the new type-based approach.
🤖 Generated with Claude Code