Remove External Zero concept #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #120
- Removed ExternalZero constant from both C# and C++ Hybrid classes - Updated IsNothing, IsExternal, and AbsoluteValue properties to use default/zero - Modified constructors to assign default value instead of ExternalZero - Updated LinksConstants to use zero as minimum external reference range - Updated corresponding unit tests This change makes regular (internal) zero become external, improving bitwise operations safety and performance with raw number conversions. Fixes #120 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the removal of the ExternalZero concept as requested in issue #120.
Changes Made
Hybrid.cs) and C++ (Hybrid.h) implementationsIsNothing: Now simply checksValue == default(C#) orValue == 0(C++)IsExternal: Uses(Value == default) || SignedValue < 0instead of ExternalZero checkAbsoluteValue: Uses(Value == default) ? 0 : Math.Abs(SignedValue)patterndefault/0instead ofExternalZerofor external zero valuesImpact
As described in the issue, this change brings:
Pros:
✅ Bitwise operations safety
✅ Better performance with conversion of raw numbers
✅ Zeros in memory managers are now searchable
Cons:
⚠️ Worse performance of memory managers (additional if branches for zero and indexing of zero values)
⚠️ Large change across the codebase
Test Results
Fixes #120
🤖 Generated with Claude Code