Fix Count logic bug in C# and C++ implementations

[konard]

Summary

Fixes the Count logic bug described in issue #359 where the Count method had incorrect logic when either source or target was 'any'.

Problem Description

The bug was in the Count method (and related Each method) where when checking links with partial restrictions:

• The original code used a single value variable that got overwritten when both conditions were checked
• If source == any, value was set to target
• If target == any, value was overwritten with source, losing the previous assignment
• This caused incorrect matching behavior

Solution

Changed the logic to handle each case separately:

• Before: Used single variable that got overwritten
• After: Handle source==any and target==any cases independently with separate conditional blocks

Files Changed

C# Implementation

• csharp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.cs (lines 393-406)

C++ Implementation

• cpp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.h (3 locations):
  • First Count method (lines 318-331)
  • Second Count method (lines 532-545)
  • Each method (lines 729-742)

Test/Example

• Added examples/count_logic_test.cs demonstrating the fix with test cases

Code Changes

Old (buggy) logic:

var value = default(TLinkAddress);
if ((source == any))
{
    value = target;
}
if ((target == any))  // This overwrites value!
{
    value = source;
}
if ((storedLinkValue.Source == value) || (storedLinkValue.Target == value))
{
    return GetOne();
}

New (fixed) logic:

if ((source == any))
{
    if ((storedLinkValue.Target == target))
    {
        return GetOne();
    }
}
if ((target == any))
{
    if ((storedLinkValue.Source == source))
    {
        return GetOne();
    }
}

Test Plan

• Added example test case showing the difference between old and new logic
• The example demonstrates specific scenarios where the bug would manifest
• All changes maintain the same public API and behavior for correct cases

Fixes #359

🤖 Generated with Claude Code