Skip to content

Conversation

@konard
Copy link
Member

@konard konard commented Sep 11, 2025

Summary

This PR renames the IsUnusedLink() method to IsDeleted() to improve code clarity and semantics.

Changes Made

  • ✅ Renamed IsUnusedLink() method to IsDeleted() in both C# and C++ implementations
  • ✅ Updated all references and usage of the method across the codebase
  • ✅ Updated method documentation to reflect the new name and clearer semantics
  • ✅ Verified changes compile successfully

Rationale

As described in issue #390, "Unused Link" has two different meanings in this context:

  • Unused Link: A link that is not used by any other link as source/target
  • Deleted Link: A link that is marked as deleted

This rename makes the distinction clearer and improves code readability.

Files Modified

C# Files

  • csharp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.cs
  • csharp/Platform.Data.Doublets/Memory/United/Generic/UnitedMemoryLinksBase.cs

C++ Files

  • cpp/Platform.Data.Doublets/Memory/Split/Generic/SplitMemoryLinksBase.h
  • cpp/Platform.Data.Doublets/Memory/United/Generic/UnitedMemoryLinksBase.h

Test Results

✅ C# project builds successfully with no compilation errors

Fixes #390

🤖 Generated with Claude Code

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #390
@konard konard self-assigned this Sep 11, 2025
konard and others added 2 commits September 11, 2025 10:36
- Renamed IsUnusedLink() method to IsDeleted() in both C# and C++ implementations
- Updated all references and usage of the method across the codebase
- Updated method documentation to reflect the new name and clearer semantics
- This change improves code clarity by distinguishing between:
  - Unused Link: Link that is not used by any other link as source/target
  - Deleted Link: Link that is marked as deleted

Fixes #390

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Rename IsUnusedLink() method to IsDeleted() Rename IsUnusedLink() method to IsDeleted() Sep 11, 2025
@konard konard marked this pull request as ready for review September 11, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename IsUnusedLink() method to IsDeleted()

2 participants