Fix AccessViolationException on application shutdown (Ctrl+C) #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #6
konard
changed the title
- Add resource tracking and safe disposal to Data.cs - Create LinksLifetimeService for application lifecycle management - Register cleanup handlers in both Startup classes - Add disposal safety in Program.cs finally block - Remove broken .editorconfig symlink This prevents memory corruption during shutdown by ensuring SplitMemoryLinks resources are properly disposed when the application receives termination signals. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Fix for Issue #6
This PR fixes the
AccessViolationExceptionthat occurs when shutting down the application with Ctrl+C.🔍 Problem Analysis
The issue was caused by improper disposal of the
SplitMemoryLinks<ulong>instance during application shutdown. When the user pressed Ctrl+C, the application would terminate abruptly without properly disposing of memory-mapped resources, leading to:✅ Solution
Implemented comprehensive resource cleanup through:
Data.csto track the disposableSplitMemoryLinksinstanceDisposeLinks()method with exception handling to prevent disposal errors from causing crashesLinksLifetimeServicehosted service to handle application stopping events📂 Files Modified
🧪 Testing
🔧 Technical Details
The solution uses ASP.NET Core's
IHostApplicationLifetimeto properly handle shutdown signals (SIGTERM/SIGINT) and ensures that:This approach is robust and follows .NET best practices for resource management in web applications.
🤖 Generated with Claude Code
Resolves #6