Fix broken benchmark image links in README.md #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #15
The benchmark images (bench_rust.png and bench_rust_log_scale.png) were accidentally deleted in commit b8573e9 when applying best practices from Comparisons.Neo4jVSDoublets. This commit restores them from git history. Also adds a detailed case study analysis documenting: - Timeline of events leading to the bug - Root cause analysis - Evidence from CI logs and git history - Proposed solutions and lessons learned Fixes #15 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🔄 Auto-restart 1/3Detected uncommitted changes from previous run. Starting new session to review and commit them. Uncommitted files: Auto-restart will stop after changes are committed or after 2 more iterations. Please wait until working session will end and give your feedback. |
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the broken benchmark image links in README.md by restoring the deleted images from git history.
Root Cause Analysis
The benchmark images (
bench_rust.pngandbench_rust_log_scale.png) were accidentally deleted in commitb8573e9("Apply best practices from Comparisons.Neo4jVSDoublets"). This commit:Docs/.gitkeepplaceholderHowever, the CI workflow's "Prepare benchmark results" step only runs on push to main/master, not on PR merges. This created a gap where images were deleted but not yet regenerated.
Changes
Docs/bench_rust.pngandDocs/bench_rust_log_scale.pngfrom git history (commit568275a).gitkeep: No longer needed since we have actual image filesdocs/case-studies/issue-15/including:Evidence
From CI run annotations:
This warning appeared even on push-to-main runs, indicating the image generation wasn't working as expected.
Test Plan
Fixes #15
🤖 Generated with Claude Code