Fix Visual Basic language parsing in top command #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #54
- Fixed issue #54 where "top Visual Basic" command was not working - The problem was that split(r"\s+", ...) was incorrectly breaking "Visual Basic" into ["Visual", "Basic"] - Added new parse_programming_languages() function to utils.py that properly handles multi-word languages - Updated top_langs() method in commands.py to use the new parsing function - Added comprehensive tests demonstrating the fix in experiments folder The fix ensures that "Visual Basic" is treated as a single language name, allowing the bot to correctly find users who have "Visual Basic" in their profiles. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed issue #54: "top Visual Basic is not working"
top_langs()method was usingsplit(r"\s+", ...)to parse language names, which incorrectly split "Visual Basic" into["Visual", "Basic"]parse_programming_languages()function that properly handles multi-word languages like "Visual Basic"top_langs()method to use the new parsing functionTest plan
experimentsfolder demonstrating the issue and fixThe bot will now correctly respond to commands like:
top Visual Basictop visual basictop Visual Basic Python🤖 Generated with Claude Code
Resolves #54