Trader: add timer to restart subscriptions if no data received #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #183
- Add SubscriptionTimeoutInterval (5 minutes) to detect silent subscription failures - Track LastTradesDataTicks and LastMarketDataTicks for both subscription streams - Implement CheckTradesTimeout and CheckMarketDataTimeout methods to monitor data flow - Update ReceiveTradesLoop and SendOrdersLoop to restart subscriptions when no data received - Fix existing Task.Delay calls to properly handle cancellation tokens Fixes issue where trades subscription was broken after 17 days of uptime. The bot now proactively restarts subscriptions if no data is received within the timeout period. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements a timer-based subscription restart mechanism to address issue #183 where trades subscription was broken after 17 days of uptime.
Changes Made
SubscriptionTimeoutIntervalconstant set to 5 minutesLastTradesDataTicksandLastMarketDataTicksCheckTradesTimeoutandCheckMarketDataTimeoutReceiveTradesLoopandSendOrdersLoop) to:Task.Delaycalls to properly handle cancellation tokensTechnical Details
Test Plan
This fix ensures the trader bot maintains reliable data streams and automatically recovers from silent subscription failures that previously required manual restarts.
🤖 Generated with Claude Code
Resolves #183