Trader Bot: Implement buy prevention logic for problematic market conditions #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #224
- Add MaxSpreadPercentToBuy and MinimumCombinedLiquidityToBuy settings - Add IsMarketConditionsSuitableForBuying method to check market conditions - Prevent buying when bid-ask spread is too wide (configurable threshold) - Prevent buying when market liquidity is too low (configurable threshold) - Apply conditions to both initial buy orders and buy order price changes - Update configuration files with sensible default values (1.0% max spread, 1M minimum liquidity) Fixes #224 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements buy prevention logic to avoid buying when market conditions make it difficult to sell later at a profit, addressing issue #224.
Changes Made
New Configuration Settings:
MaxSpreadPercentToBuy: Maximum allowed bid-ask spread percentage (default: 1.0%)MinimumCombinedLiquidityToBuy: Minimum required combined liquidity at best bid/ask (default: 1,000,000)New Market Condition Checks:
IsMarketConditionsSuitableForBuying()method that checks:Applied Prevention Logic to:
Configuration Updates
Updated both
appsettings.TMON.jsonandappsettings.TRUR.jsonwith sensible default values:How It Works
The bot will now refuse to buy when:
This prevents the scenario described in issue #224 where the bot would buy in conditions that make it "much harder to sell" later.
Test Plan
Related Issues
Fixes #224
🤖 Generated with Claude Code