TraderBot: Remove LoadOperationsFrom from config and implement automatic calculation #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #245
…ulation The LoadOperationsFrom setting has been removed from configuration files and is now calculated automatically. The system uses the maximum of either the account open date or 30 days ago as the starting point for loading operations, preventing the need for manual updates that could cause errors. Changes: - Made LoadOperationsFrom nullable in TradingSettings - Removed LoadOperationsFrom from both appsettings files - Implemented automatic calculation logic in TradingService constructor - Updated README.md to remove documentation for the removed setting - Added informative logging for both configured and calculated values 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LoadOperationsFromsetting from configuration files (appsettings.TMON.jsonandappsettings.TRUR.json)Problem Solved
The manual
LoadOperationsFromsetting was prone to becoming stale and causing errors when not updated regularly. This change eliminates the need for manual maintenance of this setting.Implementation Details
LoadOperationsFromproperty nullable inTradingSettingsclassTradingServiceconstructorMax(accountOpenDate, thirtyDaysAgo)to determine the optimal starting pointREADME.mdto remove the obsolete settingTest plan
🤖 Generated with Claude Code
Resolves #245