-
Notifications
You must be signed in to change notification settings - Fork 45
Add minimal gS for BB and GL #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vlussenburg
wants to merge
8
commits into
linear-b:main
Choose a base branch
from
vlussenburg:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
12df526
Refactor automation settings in gitstream-bb.cm
vlussenburg 359ae83
Refactor AI service actions and comments in config
vlussenburg e1061e0
Merge branch 'main' into patch-2
vim-zz 5d29d7d
Update code review guidelines in gitstream-bb.cm
vlussenburg 829a33f
Update code review guidelines to focus on critical issues
vlussenburg b7359ed
Modify experts filter in gitStream-gl.cm
vlussenburg a64c694
Remove top limit for code experts in configuration
vlussenburg 7135850
Merge branch 'main' into patch-2
vim-zz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,86 +1,63 @@ | ||
| # -*- mode: yaml -*- | ||
| # This example configuration provides basic automations to get started with gitStream. | ||
| # View the gitStream quickstart for more examples: https://docs.gitstream.cm/examples/ | ||
| manifest: | ||
| version: 1.0 | ||
|
|
||
|
|
||
| automations: | ||
| # Use LinearB's AI service to review the changes | ||
| linearb_ai_review: | ||
| linearb_ai_codereview: | ||
| if: | ||
| - {{ not pr.draft }} | ||
| - {{ not is.bot }} | ||
| run: | ||
| - action: code-review@v1 | ||
| args: | ||
| approve_on_LGTM: {{ calc.safe_changes }} | ||
| guidelines: | | ||
| - Highlight **critical issues** only (correctness/logic, performance, security, maintainability blockers). | ||
| - Skip nitpicks; ignore null-reference risks that are known to be validated earlier in this code path. | ||
| - Keep suggestions short and actionable. | ||
| # Use LinearB's AI service to add a description to the PR | ||
| linearb_ai_description: | ||
| pr_policy_low_noise: | ||
| if: | ||
| - {{ not pr.draft }} | ||
| - {{ not (is.bot_author or is.bot_branch) }} | ||
| - {{ not is.bot }} | ||
| run: | ||
| # AI description (updates PR body; not a comment) | ||
| - action: describe-changes@v1 | ||
| args: | ||
| concat_mode: append | ||
|
|
||
| # Add a label indicating how long it will take to review the PR. | ||
| estimated_time_to_review: | ||
| if: | ||
| - true | ||
| run: | ||
| - action: add-label@v1 | ||
| # Assign reviewers silently | ||
| - action: add-reviewers@v1 | ||
| args: | ||
| label: "{{ calc.etr }} min review" | ||
| color: {{ colors.red if (calc.etr >= 20) else ( colors.yellow if (calc.etr >= 5) else colors.green ) }} | ||
| # Inform PR authors when they fail to reference Jira tickets in the PR title or description. | ||
| label_missing_jira_info: | ||
| if: | ||
| - {{ not (has.jira_ticket_in_title or has.jira_ticket_in_desc) }} | ||
| run: | ||
| - action: add-label@v1 | ||
| args: | ||
| label: "missing-jira" | ||
| color: {{ colors.red }} | ||
| reviewers: {{ who.experts }} | ||
|
|
||
| # ONE consolidated, updatable comment | ||
| - action: add-comment@v1 | ||
| args: | ||
| comment: | | ||
| This PR is missing a Jira ticket reference in the title or description. | ||
| Please add a Jira ticket reference to the title or description of this PR. | ||
| # Post a comment that lists the best experts for the files that were modified. | ||
| explain_code_experts: | ||
| if: | ||
| - true | ||
| run: | ||
| - action: explain-code-experts@v1 | ||
| args: | ||
| gt: 10 | ||
| ## gitStream Summary — Low Noise (Staff Engineer focus) | ||
| **AI PR Description:** Updated in the PR body above. | ||
| **ETR:** {{ calc.etr }} min review | ||
| **Unresolved threads:** {{ pr.unresolved_threads | default(value=0) }} | ||
| **JIRA:** {{ '✅ Found in title/description.' if (has.jira_ticket_in_title or has.jira_ticket_in_desc) else '⚠️ Missing Jira ticket. Please add one (e.g., `ABC-123` or an `atlassian.net/browse/...` link).' }} | ||
| # +----------------------------------------------------------------------------+ | ||
| # | Custom Expressions | | ||
| # | https://docs.gitstream.cm/how-it-works/#custom-expressions | | ||
| # +----------------------------------------------------------------------------+ | ||
| ### Suggested Reviewers (auto-assigned) | ||
| {{ who.experts }} | ||
| # ----------------- config ----------------- | ||
| calc: | ||
| etr: {{ branch | estimatedReviewTime }} | ||
| safe_changes: {{ is.formatting or is.docs or is.tests or is.image }} | ||
|
|
||
| has: | ||
| jira_ticket_in_title: {{ pr.title | includes(regex=r/\b[A-Za-z]+-\d+\b/) }} | ||
| jira_ticket_in_desc: {{ pr.description | includes(regex=r/atlassian.net\/browse\/\w{1,}-\d{3,4}/) }} | ||
| jira_ticket_in_title: {{ pr.title | includes(regex=r/\b[A-Za-z][A-Za-z0-9_]+-\d+\b/) }} | ||
| jira_ticket_in_desc: {{ pr.description | includes(regex=r/\b[A-Za-z][A-Za-z0-9_]+-\d+\b/) }} | ||
|
|
||
| colors: | ||
| red: 'b60205' | ||
| yellow: 'fbca04' | ||
| green: '0e8a16' | ||
| who: | ||
| experts: {{ repo | codeExperts(gt=10, top=5) }} | ||
|
|
||
| is: | ||
| formatting: {{ source.diff.files | isFormattingChange }} | ||
| docs: {{ files | allDocs }} | ||
| tests: {{ files | allTests }} | ||
| image: {{ files | allImages }} | ||
| bot_author: {{ pr.author | match(list=['github-actions', '_bot_', '[bot]', 'dependabot']) | some }} | ||
| bot_branch: {{ branch.name | match(list=['renovate/']) | some }} | ||
| bot: {{ pr.author | match(list=['github-actions','_bot_','[bot]','dependabot','gitstream-cm','prvalidation','aida-bot']) | some }} | ||
|
|
||
| colors: | ||
| red: 'b60205' | ||
| yellow: 'fbca04' | ||
| green: '0e8a16' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,82 +1,63 @@ | ||
| # -*- mode: yaml -*- | ||
| # This example configuration provides basic automations to get started with gitStream. | ||
| # View the gitStream quickstart for more examples: https://docs.gitstream.cm/examples/ | ||
| manifest: | ||
| version: 1.0 | ||
|
|
||
|
|
||
| automations: | ||
| # Use LinearB's AI service to review the changes | ||
| linearb_ai_review: | ||
| linearb_ai_codereview: | ||
| if: | ||
| - {{ not pr.draft }} | ||
| - {{ not (is.bot_author or is.bot_branch) }} | ||
| - {{ not is.bot }} | ||
| run: | ||
| - action: code-review@v1 | ||
| args: | ||
| approve_on_LGTM: {{ calc.safe_changes }} | ||
| guidelines: | | ||
| - Highlight **critical issues** only (correctness/logic, performance, security, maintainability blockers). | ||
| - Skip nitpicks; ignore null-reference risks that are known to be validated earlier in this code path. | ||
| - Keep suggestions short and actionable. | ||
vlussenburg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # Use LinearB's AI service to add a description to the PR | ||
| linearb_ai_description: | ||
| pr_policy_low_noise: | ||
| if: | ||
| - {{ not pr.draft }} | ||
| - {{ not (is.bot_author or is.bot_branch) }} | ||
| - {{ not is.bot }} | ||
| run: | ||
| # AI description (updates PR body; not a comment) | ||
| - action: describe-changes@v1 | ||
| args: | ||
| concat_mode: append | ||
|
|
||
| # Add a label indicating how long it will take to review the PR. | ||
| estimated_time_to_review: | ||
| if: | ||
| - true | ||
| run: | ||
| - action: add-comment@v1 | ||
| # Assign reviewers silently | ||
| - action: add-reviewers@v1 | ||
| args: | ||
| comment: "{{ calc.etr }} min review" | ||
| reviewers: {{ who.experts }} | ||
|
|
||
| # Request changes by PR authors when they fail to reference Jira tickets in the PR title or description. | ||
| request_missing_jira_info: | ||
| if: | ||
| - {{ not (has.jira_ticket_in_title or has.jira_ticket_in_desc) }} | ||
| run: | ||
| - action: request-changes@v1 | ||
| # ONE consolidated, updatable comment | ||
| - action: add-comment@v1 | ||
| args: | ||
| comment: | | ||
| This PR is missing a Jira ticket reference in the title or description. | ||
| Please add a Jira ticket reference to the title or description of this PR. | ||
| # Post a comment that lists the best experts for the files that were modified. | ||
| explain_code_experts: | ||
| if: | ||
| - true | ||
| run: | ||
| - action: explain-code-experts@v1 | ||
| args: | ||
| gt: 10 | ||
| ## gitStream Summary — Low Noise (Staff Engineer focus) | ||
| **AI PR Description:** Updated in the PR body above. | ||
| **ETR:** {{ calc.etr }} min review | ||
| **Unresolved threads:** {{ pr.unresolved_threads | default(value=0) }} | ||
| **JIRA:** {{ '✅ Found in title/description.' if (has.jira_ticket_in_title or has.jira_ticket_in_desc) else '⚠️ Missing Jira ticket. Please add one (e.g., `ABC-123` or an `atlassian.net/browse/...` link).' }} | ||
| # +----------------------------------------------------------------------------+ | ||
| # | Custom Expressions | | ||
| # | https://docs.gitstream.cm/how-it-works/#custom-expressions | | ||
| # +----------------------------------------------------------------------------+ | ||
| ### Suggested Reviewers (auto-assigned) | ||
| {{ who.experts }} | ||
| # ----------------- config ----------------- | ||
| calc: | ||
| etr: {{ branch | estimatedReviewTime }} | ||
| safe_changes: {{ is.formatting or is.docs or is.tests or is.image }} | ||
|
|
||
| has: | ||
| jira_ticket_in_title: {{ pr.title | includes(regex=r/\b[A-Za-z]+-\d+\b/) }} | ||
| jira_ticket_in_desc: {{ pr.description | includes(regex=r/atlassian.net\/browse\/\w{1,}-\d{3,4}/) }} | ||
| jira_ticket_in_title: {{ pr.title | includes(regex=r/\b[A-Za-z][A-Za-z0-9_]+-\d+\b/) }} | ||
| jira_ticket_in_desc: {{ pr.description | includes(regex=r/\b[A-Za-z][A-Za-z0-9_]+-\d+\b/) }} | ||
|
|
||
| colors: | ||
| red: 'b60205' | ||
| yellow: 'fbca04' | ||
| green: '0e8a16' | ||
| who: | ||
| experts: {{ repo | codeExperts(gt=10, top=5) }} | ||
|
||
|
|
||
| is: | ||
| formatting: {{ source.diff.files | isFormattingChange }} | ||
| docs: {{ files | allDocs }} | ||
| tests: {{ files | allTests }} | ||
| image: {{ files | allImages }} | ||
| bot_author: {{ pr.author | match(list=['github-actions', '_bot_', '[bot]', 'dependabot']) | some }} | ||
| bot_branch: {{ branch.name | match(list=['renovate/']) | some }} | ||
| bot: {{ pr.author | match(list=['github-actions','_bot_','[bot]','dependabot','gitstream-cm','prvalidation','aida-bot']) | some }} | ||
|
|
||
| colors: | ||
| red: 'b60205' | ||
| yellow: 'fbca04' | ||
| green: '0e8a16' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.