Remove check_added_monitors macro
#4238
Conversation
|
I've assigned @wpaulino as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4238 +/- ##
==========================================
+ Coverage 89.33% 89.34% +0.01%
==========================================
Files 180 180
Lines 139302 139304 +2
Branches 139302 139304 +2
==========================================
+ Hits 124439 124462 +23
+ Misses 12240 12217 -23
- Partials 2623 2625 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| use lightning::ln::functional_test_utils::expect_payment_sent; | ||
| use lightning::ln::functional_test_utils::test_default_channel_config; | ||
| use lightning::ln::functional_test_utils::SendEvent; | ||
| use lightning::ln::functional_test_utils::{check_added_monitors, create_funding_transaction}; |
There was a problem hiding this comment.
We usually just import lightning::ln::functional_test_utils::*, no need to import all of these manually. There are a few more like this throughout the diff as well.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
elnosh
force-pushed
the
remove-testutils-macros
branch
from
b5e05cd to
51de9f2
Compare
| @@ -1,14 +1,11 @@ | |||
| use lightning::check_closed_broadcast; | |||
There was a problem hiding this comment.
Wouldn't I still need it? since macros are available at the root of the crate. Removing it fails, I don't think it is imported as part of use lightning::ln::functional_test_utils::*;. Same for the other ones.
| check_added_monitors, check_spends, get_local_commitment_txn, get_monitor, | ||
| get_route_and_payment_hash, | ||
| }; | ||
| use crate::{check_spends, get_local_commitment_txn, get_monitor, get_route_and_payment_hash}; |
| mod tests { | ||
| use super::*; | ||
| use crate::chain::ChannelMonitorUpdateStatus; | ||
| use crate::check_closed_broadcast; |
|
Looks like this needs rebase now @elnosh |
Replace calls to `check_added_monitors` macro to the identically-named function.
elnosh
force-pushed
the
remove-testutils-macros
branch
from
51de9f2 to
8423ffa
Compare
4 participants
No description provided.