Skip to content

fix constructor assembly return #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mookim-eth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix constructor assembly return #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/FreeENS.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ contract FreeENS {
}
}

// insure abi encoding, not needed here but increase reusability for different return types
// note: abi.encode add a first 32 bytes word with the address of the original data
// ensure abi encoding, not needed here but increase reusability for different return types
// note: abi.encode add a first 32 bytes word with the length of the original data
bytes memory _abiEncodedData = abi.encode(r);

assembly {
// Return from the start of the data (discarding the original data address)
// up to the end of the memory used
// Return from the start of the data (skipping the data length field)
// mload(bytes) returns the length of the bytes variable
let dataStart := add(_abiEncodedData, 0x20)
return(dataStart, sub(msize(), dataStart))
return(dataStart, mload(_abiEncodedData))
}
}
}