help GHA #21
Merged
help GHA #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @osu1191 and @slipchenko, this gets the continuous integration checks going a little further. C and Python libraries build fine again, C tests fine, and Python passes about half the tests. (But notably doesn't segfault, so that trouble was probably with your local environment.) All the failing tests are with the polarization term. Maybe your lj and mm additions will help, Suranjan? I don't see anywhere in #20 (tests seem to have been working before then) when defaults change, which I'd think would be the main thing that would cause terms to break. Hopefully this can help with your debugging. The error in the Windows lane is something different, but I think Linux is first priority.