Skip to content

Rely on http protocol public start. #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Dec 26, 2025
+2 −10
Merged

Rely on http protocol public start. #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol_bitcoind_rest.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class BCN_API protocol_bitcoind_rest
{
}

/// Public start is required.
void start() NOEXCEPT override;
void stopping(const code& ec) NOEXCEPT override;

Expand Down
1 change: 0 additions & 1 deletion include/bitcoin/node/protocols/protocol_bitcoind_rpc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ class BCN_API protocol_bitcoind_rpc
{
}

/// Public start is required.
void start() NOEXCEPT override;
void stopping(const code& ec) NOEXCEPT override;

Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/node/protocols/protocol_stratum_v1.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class BCN_API protocol_stratum_v1
}

/// Public start is required.
void start() NOEXCEPT override
inline void start() NOEXCEPT override
{
node::protocol_rpc::start();
}
Expand Down
2 changes: 1 addition & 1 deletion include/bitcoin/node/protocols/protocol_stratum_v2.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class BCN_API protocol_stratum_v2
}

/// Public start is required.
void start() NOEXCEPT override
inline void start() NOEXCEPT override
{
node::protocol_tcp::start();
}
Expand Down
6 changes: 0 additions & 6 deletions include/bitcoin/node/protocols/protocol_web.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,6 @@ class BCN_API protocol_web
network::tracker<protocol_web>(session->log)
{
}

/// Public start is required.
inline void start() NOEXCEPT override
{
node::protocol_html::start();
}
};

} // namespace node
Expand Down
Loading