-
Notifications
You must be signed in to change notification settings - Fork 190
feat: add hover styles to cards #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hover styles to cards #1198
Conversation
|
@luighis is attempting to deploy a commit to the LFG Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
WalkthroughThe update modifies the CSS classes applied to the root div of the DefiOpportunityCardComponent. The new classes introduce a more elaborate hover effect, including vertical translation, a custom background color, and a shadow, using smooth transitions. No changes were made to the component's structure or functionality. Changes
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~2 minutes Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. π§ ESLint
npm error code ERESOLVE ... [truncated 730 characters] ... error node_modules/@typescript-eslint/eslint-plugin Note β‘οΈ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. β¨ Finishing Touches
π§ͺ Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi @Marchand-Nicolas , check the PR, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
components/discover/defiOpportunityCard.tsx(1 hunks)
π§° Additional context used
π§ Learnings (2)
π Common learnings
Learnt from: fricoben
PR: lfglabs-dev/starknet.quest#963
File: components/discover/defiTable.tsx:418-456
Timestamp: 2024-11-25T01:01:20.940Z
Learning: When displaying opportunity cards in the `DataTable` component (`components/discover/defiTable.tsx`), ensure that data is rendered dynamically based on the current filters and sorting applied, avoiding hardcoded values.
Learnt from: baitcode
PR: lfglabs-dev/starknet.quest#962
File: app/page.tsx:34-34
Timestamp: 2024-11-27T07:42:52.459Z
Learning: In this project, updating the Card component to use Next.js Image component is considered out of scope.
components/discover/defiOpportunityCard.tsx (5)
Learnt from: fricoben
PR: #963
File: components/discover/defiTable.tsx:418-456
Timestamp: 2024-11-25T01:01:20.940Z
Learning: When displaying opportunity cards in the DataTable component (components/discover/defiTable.tsx), ensure that data is rendered dynamically based on the current filters and sorting applied, avoiding hardcoded values.
Learnt from: baitcode
PR: #962
File: app/page.tsx:34-34
Timestamp: 2024-11-27T07:42:52.459Z
Learning: In this project, updating the Card component to use Next.js Image component is considered out of scope.
Learnt from: baitcode
PR: #962
File: components/pages/home/splitTitle.tsx:373-392
Timestamp: 2024-11-27T07:25:07.612Z
Learning: In the SplitTitle component (components/pages/home/splitTitle.tsx), the use of Math.random() in the getVariants function is intentional to create unpredictable animations.
Learnt from: joeperpetua
PR: #870
File: components/discover/tokenIcon.tsx:19-29
Timestamp: 2024-10-11T11:08:32.705Z
Learning: In the TokenIcon component (components/discover/tokenIcon.tsx), when an unknown token is encountered, default to using the USDC icon, consistent with the implementation in TokenSymbol (components/quest-boost/TokenSymbol.tsx).
Learnt from: baitcode
PR: #962
File: components/pages/home/splitTitle.tsx:3-3
Timestamp: 2024-11-27T07:26:15.265Z
Learning: In the file components/pages/home/splitTitle.tsx, the motion library is correctly imported from motion/react rather than framer-motion.
Marchand-Nicolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, great job, lgtm! :D
π Features
β Added styles when hovering over cards
β The animations and colors are consistent with the other cards, improving the user experience.
closes #1168
Grabacion.de.pantalla.2025-07-26.a.la.s.1.01.41.a.m.mov
Summary by CodeRabbit