Fix: Update starknet kit and starknet js #1195

akintewe · 2025-07-23T14:41:03Z

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Resolves: #1194

Description

This PR updates the Starknet.js and StarknetKit packages to their latest stable versions and implements the new "Ready" branding for Argent wallet in the connection menu.

Changes Made:

Package Updates:
- Updated starknet.js from ^6.11.0 to 7.6.4
- Updated starknetkit from ^2.6.1 to 3.0.1
Wallet Name Updates:
- Changed "Argent X" to "Ready" in wallet configuration
- Changed "Argent (mobile)" to "Ready" in wallet configuration
- Updated connector configuration to use "Ready" branding
Breaking Changes Fixed:
- Updated isRejected() method calls to isReverted() in:
  - components/UI/notifications/notificationDetail.tsx
  - hooks/useNotificationManager.ts

Testing:

✅ Development server runs successfully
✅ Build completes without errors
✅ Wallet connectors properly initialized with new names
✅ No breaking functionality introduced

Files Modified:

package.json - Updated dependencies
package-lock.json - Updated lock file
utils/walletConfig.ts - Updated wallet names
components/UI/notifications/notificationDetail.tsx - Fixed breaking changes
hooks/useNotificationManager.ts - Fixed breaking changes

Other information

This PR addresses issue #1194 to update the wallet connection menu to display "Ready" instead of "Argent" for the Argent wallet provider, ensuring the updated branding is reflected in the UI when users choose a wallet provider.

Close #1194

Summary by CodeRabbit

Bug Fixes
- Improved transaction status handling in notifications to more accurately reflect reverted transactions as errors.
New Features
- Updated wallet display names for "argentX" and "argentMobile" to "Ready" throughout the app.
Tests
- Adjusted test cases to match the new wallet display names.
Chores
- Upgraded dependencies for improved compatibility and performance.

vercel · 2025-07-23T14:41:10Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 0:54am

vercel · 2025-07-23T14:41:11Z

@akintewe is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2025-07-23T14:45:01Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update modifies wallet naming from "Argent X" and "Argent (mobile)" to "Ready" in both configuration and tests, updates related connector instantiation, and upgrades the starknet and starknetkit package versions. Additionally, transaction status logic is adjusted to treat only reverted (not rejected) transactions as errors in notifications.

Changes

File(s)	Change Summary
components/UI/notifications/notificationDetail.tsx	Replaced all checks for `isRejected()` with `isReverted()` in notification status and icon logic.
hooks/useNotificationManager.ts	Modified transaction status logic to only treat `isReverted()` as error, removing `isRejected()`.
package.json	Updated `starknet` from `^6.11.0` to `^6.24.1` and `starknetkit` from `^2.6.1` to `^2.12.1`.
utils/walletConfig.ts, tests/utils/walletConfig.test.js	Renamed wallet display names from "Argent X"/"Argent (mobile)" to "Ready" and updated related tests.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant NotificationManager
    participant WalletConfig

    User->>UI: Initiate wallet connection
    UI->>WalletConfig: Fetch wallet options
    WalletConfig-->>UI: Return wallet list (with "Ready" as name)
    UI->>User: Display wallet options ("Ready" shown)
    User->>UI: Submit transaction
    UI->>NotificationManager: Monitor transaction status
    NotificationManager->>UI: Notify only if transaction is reverted (not rejected)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Update starknet kit and starknet js app.starknet.id#1181: The changes directly update wallet display names to "Ready" and upgrade Starknet.js and StarknetKit, matching the objectives of this issue.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Marchand-Nicolas

Hey it doesn't build, you can debug using npm run build. You can also try deleting the package-lock.json file

akintewe · 2025-07-24T12:12:09Z

Hey it doesn't build, you can debug using npm run build. You can also try deleting the package-lock.json file

you can try it now

Marchand-Nicolas

Great job :D
Lgtm!!

Marchand-Nicolas · 2025-07-26T19:08:12Z

Thanks for notifying me @akintewe I forgot to merge!

Fix: Update wallet name from Argent to Ready in connection menu

c784ac8

vercel bot had a problem deploying to Preview – starknet-quest July 23, 2025 14:43 Failure

Fix: Update test expectations to match new Ready wallet name

aa27f0b

vercel bot had a problem deploying to Preview – starknet-quest July 23, 2025 14:47 Failure

Marchand-Nicolas requested changes Jul 24, 2025

View reviewed changes

Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Jul 24, 2025

Fix: Resolve build issues by downgrading to compatible starknet versions

82f1431

akintewe requested a review from Marchand-Nicolas July 24, 2025 12:11

vercel bot deployed to Preview – starknet-quest July 24, 2025 12:12 View deployment

Marchand-Nicolas reviewed Jul 25, 2025

View reviewed changes

Marchand-Nicolas approved these changes Jul 25, 2025

View reviewed changes

Merge branch 'testnet' into pr/akintewe/1195

7f4b775

vercel bot deployed to Preview – starknet-quest July 25, 2025 12:54 View deployment

akintewe requested a review from Marchand-Nicolas July 26, 2025 18:44

Marchand-Nicolas merged commit 41212c7 into lfglabs-dev:testnet Jul 26, 2025
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Update starknet kit and starknet js #1195

Fix: Update starknet kit and starknet js #1195

Uh oh!

akintewe commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 23, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 23, 2025

Uh oh!

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Marchand-Nicolas left a comment

Uh oh!

akintewe commented Jul 24, 2025

Uh oh!

Marchand-Nicolas left a comment

Uh oh!

Uh oh!

Marchand-Nicolas commented Jul 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix: Update starknet kit and starknet js #1195

Fix: Update starknet kit and starknet js #1195

Uh oh!

Conversation

akintewe commented Jul 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request type

Description

Changes Made:

Testing:

Files Modified:

Other information

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jul 23, 2025

Uh oh!

coderabbitai bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related issues

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

Uh oh!

akintewe commented Jul 24, 2025

Uh oh!

Marchand-Nicolas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Marchand-Nicolas commented Jul 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akintewe commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 23, 2025 •

edited

Loading

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)